Skip to content

fix(directives): field node directives property is optional #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2020
Merged

fix(directives): field node directives property is optional #34

merged 1 commit into from
Nov 1, 2020

Conversation

hekike
Copy link
Contributor

@hekike hekike commented Oct 28, 2020 •
edited
Loading

Hi, thanks for the module, it's a great help!
I run into an issue where my application faisl when FieldNode doesn't have directives.
As directives is an optional property on FieldNode, I created this PR to address this issue.

FieldNode.directives is an optional property:
https://github.com/graphql/graphql-js/blob/7b3241329e1ff49fb647b043b80568f0cf9e1a7c/src/language/ast.js#L296-L304

Please let me know if you need a change to proceed with it.

@ivome
Copy link
Collaborator

ivome commented Nov 1, 2020

@hekike Thank you for the fix!

@ivome ivome merged commit 10b4456 into slicknode:master Nov 1, 2020
@hekike hekike deleted the fix/field-node-directives-optional branch November 2, 2020 16:41
@hekike
Copy link
Contributor Author

hekike commented Nov 2, 2020

thanks for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hekike @ivome